chore: Clean up some code #12287
Open
chore: Clean up some code #12287
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
tomi
force-pushed
the
chore-clean-up-code
branch
from
7ab2808 to
00e9100
Compare
tomi
force-pushed
the
chore-clean-up-code
branch
from
00e9100 to
df878cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
|
n8n
|
||||||||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
chore-clean-up-code
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
479
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
e2e/45-workflow-selector-parameter.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Workflow Selector Parameter > should render add resource option and redirect to the correct route when clicked |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clean up some code
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)